Java 17 Upgrade #21
Open
Java 17 Upgrade #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaneja
reviewed
Oct 10, 2024
| @@ -20,7 +20,7 @@ | |||
| <properties> | |||
| <mavenVersion>3.8.1</mavenVersion> | |||
| <mavenPluginPluginVersion>3.2</mavenPluginPluginVersion> | |||
| <provisioVersion>0.1.40</provisioVersion> | |||
| <provisioVersion>1.0.18</provisioVersion> | |||
| <takari.javaSourceVersion>1.8</takari.javaSourceVersion> | |||
There was a problem hiding this comment.
Any clue what this references and would it need an upgrade ?
There was a problem hiding this comment.
It's getting referenced just a few lines below for setting language level. Probably once we want to change the language level we will have to update this property as well.
beinan
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Thank you @imjalpreet ! it looks good to me, feel free to ping me if you need any review for jdk upgrade, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: prestodb/presto#23788