Add Windows path separator support. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this patch, Presto plugin can be packaged on Windows.
hgschmie
suggested changes
Feb 18, 2018
| @@ -119,7 +119,7 @@ private URLClassLoader createClassloaderFromCompileTimeDependencies() | |||
| List<Class<?>> implementations = Lists.newArrayList(); | |||
| List<String> classes = FileUtils.getFileNames(classesDirectory, "**/*.class", null, false); | |||
| for (String classPath : classes) { | |||
| String className = classPath.substring(0, classPath.length() - 6).replace('/', '.'); | |||
| String className = classPath.substring(0, classPath.length() - 6).replace('/', '.').replace('\\', '.'); | |||
There was a problem hiding this comment.
Wouldn't it make it more sense, instead of adding another replace to change the existing one into
.replace(File.separatorChar, '.')
which would work on any operating system?
|
i have run into the problem when compiling presto, see prestodb/presto#11818 I think this PR will solve the problem, anyone can merge this?? |
|
Can anyone merge this? |
|
The PR allows to build Presto on Windows because it fixes the following issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch, Presto plugin can be packaged on Windows.