Skip to content

Conversation

@zoltan
Copy link
Contributor

@zoltan zoltan commented Nov 5, 2025

Description

Once Velox PR #15404 is merged in, it will be possible to signal Velox that the particular PartitionedOutputNode will be used only to hold data for the coordinator as the final output of a plan. This is set to false by default, however, to properly translate OutputNode, we need to set this to true.

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

== NO RELEASE NOTE ==

Once Velox PR prestodb#15404 is merged in, it will be possible to signal Velox
that the particular PartitionedOutputNode will be used only to hold
data for the coordinator as the final output of a plan. This is set to
false by default, however, to properly translate OutputNode, we need to
set this to true.
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Nov 5, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 5, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

When translating an OutputNode, the PartitionedOutputNode constructor now receives an explicit true for the rootFragment flag, ensuring the node is marked as the final coordinator output.

Class diagram for updated PartitionedOutputNode construction

classDiagram
    VeloxQueryPlanConverterBase <|-- VeloxInteractiveQueryPlanConverter
    class VeloxQueryPlanConverterBase {
        +toVeloxQueryPlan(node, tableWriteInfo, taskId)
    }
    class PartitionedOutputNode {
        +id
        +rowType
        +serdeKind
        +source
        +rootFragment: bool
    }
    VeloxQueryPlanConverterBase --> PartitionedOutputNode : constructs
    PartitionedOutputNode : +rootFragment = true (now set explicitly for OutputNode)
Loading

File-Level Changes

Change Details Files
Set rootFragment flag to true for translated OutputNode
  • Add true as the final argument in the PartitionedOutputNode constructor call
  • Update call to toVeloxQueryPlan to match new constructor signature
presto-native-execution/presto_cpp/main/types/PrestoToVeloxQueryPlan.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants