fix(native): Incorrect session property hidden attribute

[czentgr]

A session property can be declared hidden.
Some session property additions set a default value instead of the hidden property. The integers were
interpreted as true.

This change fixes the attribute to true or false.
It is set to false for documented session properties and true for undocumented properties at the time of addition.

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

• Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.
• If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Replace integer literals used for hidden attribute in session property definitions with explicit boolean flags (false for documented, true for undocumented) and fix a typo in a property description.

Entity relationship diagram for session property hidden attribute update

erDiagram
    SESSION_PROPERTY {
        string name
        string description
        string type
        boolean hidden
        string config_key
        string default_value
    }
    SESSION_PROPERTIES {
        string id
    }
    SESSION_PROPERTIES ||--o{ SESSION_PROPERTY : contains

Loading

Class diagram for updated SessionProperty construction

classDiagram
    class SessionProperty {
        +string name
        +string description
        +Type type
        +bool hidden
        +string configKey
        +string defaultValue
    }
    class SessionProperties {
        +SessionProperties()
        +addSessionProperty(name, description, type, hidden, configKey, defaultValue)
    }
    SessionProperties --> SessionProperty : manages

Loading

File-Level Changes

Change	Details	Files
Session property hidden flags corrected to explicit booleans	Replaced integer defaults with false for documented properties Replaced integer defaults with true for undocumented properties Updated six session property definitions to use boolean hidden flags	presto-native-execution/presto_cpp/main/SessionProperties.cpp
Typo fixed in session property description	Corrected spelling from "Prefered" to "Preferred" in description	presto-native-execution/presto_cpp/main/SessionProperties.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.