fix: Throw USER_ERROR instead of FUNCTION_IMPLEMENTATION_MISSING for unsupported parameters

[amitkdutta]

Description

Throwing proper error code for better error classification.

Motivation and Context

We see queries failing with Unsupported type parameters (BoundVariables{typeVariables={T=array(varchar)}, longVariables={}}) for presto.default.approx_distinct<T>(T):bigint where parmater isn't supported. This is simply user error (also the error message suggests so). Throwing user error code in this case reudce unnecessary retry, miscategorization and send proper signal to users.

Impact

None

Test Plan

Existing

== NO RELEASE NOTE ==

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update the error code thrown in scalar function specialization for unsupported type parameters from FUNCTION_IMPLEMENTATION_MISSING to NOT_SUPPORTED to ensure proper user error classification.

Class diagram for updated error handling in ParametricScalar

classDiagram
class ParametricScalar {
  +specialize(boundVariables)
}
ParametricScalar --> PrestoException
class PrestoException {
  +PrestoException(errorCode, message)
}
%% Error codes used
class FUNCTION_IMPLEMENTATION_MISSING
class NOT_SUPPORTED
PrestoException --> FUNCTION_IMPLEMENTATION_MISSING
PrestoException --> NOT_SUPPORTED

Loading

File-Level Changes

Change	Details	Files
Switch error code for unsupported type parameters	Changed thrown PrestoException from FUNCTION_IMPLEMENTATION_MISSING to NOT_SUPPORTED Updated import to reference NOT_SUPPORTED error code	presto-main-base/src/main/java/com/facebook/presto/operator/scalar/ParametricScalar.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[swapsmagic]

Can we introduce unit or integration tests to make sure this functionality has been verified?

[swapsmagic]

Let's add unit test and should be good to merge.