Fix doc about Magikarp length calculation and bugfix doc

pret · Dec 24, 2023 · 6508421 · 6508421
1 parent 9a917e3
commit 6508421
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/docs/bugs_and_glitches.md b/docs/bugs_and_glitches.md
@@ -2416,6 +2416,7 @@ CopyPokemonName_Buffer1_Buffer3:
  	cp d
  	ret c
 -	ret nc
++	ret nz
  	ld a, c
  	cp e
  	ret

diff --git a/engine/events/magikarp.asm b/engine/events/magikarp.asm
@@ -110,7 +110,7 @@ CalcMagikarpLength:
 
 ; This function is poorly commented.
 
-; In short, it generates a value between 190 and 1786 using
+; In short, it generates a value between 190 and 1625 using
 ; a Magikarp's DVs and its trainer ID. This value is further
 ; filtered in LoadEnemyMon to make longer Magikarp even rarer.
-Original file line number
+Diff line change
@@ Expand Up / @@ -2416,6 +2416,7 @@ CopyPokemonName_Buffer1_Buffer3: @@
      	cp d
      	ret c
     -	ret nc
+    +	ret nz
      	ld a, c
      	cp e
      	ret
@@ Expand Down @@