Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document SFX_RUN does not play correctly when a wild Pokemon flees from battle #1099

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Document SFX_RUN does not play correctly when a wild Pokemon flees from battle #1099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions docs/bugs_and_glitches.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ Fixes in the [multi-player battle engine](#multi-player-battle-engine) category
- [Team Rocket battle music is not used for Executives or Scientists](#team-rocket-battle-music-is-not-used-for-executives-or-scientists)
- [No bump noise if standing on tile `$3E`](#no-bump-noise-if-standing-on-tile-3e)
- [Playing Entei's Pokédex cry can distort Raikou's and Suicune's](#playing-enteis-pok%C3%A9dex-cry-can-distort-raikous-and-suicunes)
- [`SFX_RUN` does not play correctly when a wild Pokemon flees from battle](#sfx_run-does-not-play-correctly-when-a-wild-pokemon-flees-from-battle)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pokémon

- [Text](#text)
- [Five-digit experience gain is printed incorrectly](#five-digit-experience-gain-is-printed-incorrectly)
- [Only the first three evolution entries can have Stone compatibility reported correctly](#only-the-first-three-evolution-entries-can-have-stone-compatibility-reported-correctly)
Expand Down Expand Up @@ -2726,3 +2727,25 @@ This bug allows all the options to be updated at once if the left or right butto
ld a, [hl]
push af
```


### `SFX_RUN` does not play correctly when a wild Pokemon flees from battle

Due to the wrong function being called, `SFX_RUN` is never heard when a wild Pokemon flees from battle.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


**Fix:** Edit `WildFled_EnemyFled_LinkBattleCanceled` in [engine/battle/core.asm]
(https://github.com/pret/pokecrystal/blob/master/engine/battle/core.asm):

```diff
.skip_text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces

-; BUG: SFX_RUN does not play correctly when a wild Pokemon flees from battle (see docs/bugs_and_glitches.md)
call StopDangerSound
call CheckMobileBattleError
jr c, .skip_sfx

ld de, SFX_RUN
- call PlaySFX
+ call WaitPlaySFX

.skip_sfx
```
1 change: 1 addition & 0 deletions engine/battle/core.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ WildFled_EnemyFled_LinkBattleCanceled:
call StdBattleTextbox

.skip_text
; BUG: SFX_RUN does not play correctly when a wild Pokemon flees from battle (see docs/bugs_and_glitches.md)
call StopDangerSound
call CheckMobileBattleError
jr c, .skip_sfx
Expand Down