Bugfix for cable car hikerGraphicsIds array #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the Cable Car transition cutscene, there's a 1/64 chance for an NPC sprite to appear walking below. The available NPCs include the Hiker, Camper, Picnicker, and Zigzagoon. However, due to the use of
ARRAY_COUNT(hikerGraphicsIds) - 1, it is impossible for Zigzagoon to appear during the cable car cutscene.It seems this is an oversight by Game Freak, as there is no clear rationale for including Zigzagoon in the array of NPCs if the intent was for it not to appear during this cutscene.
Proposed solution: remove the
- 1from the array count.Discord contact info
Scyrous