Documenting code for the Stats Judge #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhearachel
reviewed
Feb 3, 2025
asm/macros/scrcmd.inc
Outdated
| @@ -4077,7 +4077,7 @@ | |||
| .short 749 | |||
| .endm | |||
|
|
|||
| .macro ScrCmd_2EE arg0, arg1, arg2, arg3 | |||
| .macro ScrCmd_JudgeStats arg0, arg1, arg2, arg3 | |||
There was a problem hiding this comment.
polish: For the ASM macro only, change the name to JudgeStats (so that scripts can reference it as such).
src/overlay005/ov5_021F6454.c
Outdated
| 0x7D, | ||
| 0x7E | ||
| // See message_bank_battle_tower.gmm | ||
| static const u16 highestIVMessageIndices[] = { |
There was a problem hiding this comment.
polish: sHighestIVMessageIndices
src/overlay005/ov5_021F6454.c
Outdated
| 0x7E | ||
| // See message_bank_battle_tower.gmm | ||
| static const u16 highestIVMessageIndices[] = { | ||
| 122, |
There was a problem hiding this comment.
polish: Replace hard-coded indices with the generated constants from message encoding. (Check out build/res/text/bank/battle_tower.h to see what I mean; you can include that file like any other C header via #include "res/text/bank/battle_tower.h")
lhearachel
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I renamed
ScrCmd_2EEtoScrCmd_JudgeStatsand documented it. That function is basically just for the stats judge (scientist guy in the battle tower) to decide what to say.