-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document scripts_pokemon_center_daily_trainers.s
#377
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e mapID / weekday script commands + use map_header / trainer constants)
cbt6
reviewed
Feb 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Prefix script command names with verbs
- Prefix constants to make them more easily grep-able
- Rename params appropriately in renamed functions
lhearachel
reviewed
Feb 14, 2025
Co-authored-by: Rachel <lhearachel@proton.me>
…latinum into document-scripts
lhearachel
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of hopefully many scripts I will document. If there's anything in naming conventions that I should change, please tell me so I can keep that in mind for those other scripts as well :)
With the documentation around this script I've made a couple new additions:
generated/weekdays.txt
constants/scrcmd.h
with general constants for in scripts (e.g.YES
/NO
)constants/flags.h
for flag constants