Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document scripts_pokemon_center_daily_trainers.s #377

Merged
merged 10 commits into from
Feb 16, 2025

Conversation

Viperio19
Copy link
Contributor

First of hopefully many scripts I will document. If there's anything in naming conventions that I should change, please tell me so I can keep that in mind for those other scripts as well :)

With the documentation around this script I've made a couple new additions:

  • commands for days of the week in generated/weekdays.txt
  • constants/scrcmd.h with general constants for in scripts (e.g. YES / NO)
  • constants/flags.h for flag constants
  • maybe some other things I forgot

Copy link
Contributor

@cbt6 cbt6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Prefix script command names with verbs
  • Prefix constants to make them more easily grep-able
  • Rename params appropriately in renamed functions

asm/macros/scrcmd.inc Outdated Show resolved Hide resolved
asm/macros/scrcmd.inc Outdated Show resolved Hide resolved
asm/macros/scrcmd.inc Outdated Show resolved Hide resolved
generated/weekdays.txt Outdated Show resolved Hide resolved
include/constants/flags.h Outdated Show resolved Hide resolved
asm/macros/scrcmd.inc Outdated Show resolved Hide resolved
asm/macros/scrcmd.inc Outdated Show resolved Hide resolved
res/field/scripts/scripts_pokemon_center_daily_trainers.s Outdated Show resolved Hide resolved
include/constants/scrcmd.h Outdated Show resolved Hide resolved
include/constants/scrcmd.h Outdated Show resolved Hide resolved
asm/macros/scrcmd.inc Outdated Show resolved Hide resolved
include/data/trainer_class_prize_mul.h Outdated Show resolved Hide resolved
include/data/trainer_class_genders.h Outdated Show resolved Hide resolved
res/field/scripts/scripts_amity_square.s Show resolved Hide resolved
src/scrcmd.c Outdated Show resolved Hide resolved
src/scrcmd.c Outdated Show resolved Hide resolved
src/scrcmd.c Outdated Show resolved Hide resolved
@lhearachel lhearachel merged commit decc172 into pret:main Feb 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants