Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect wTilePlayerStandingOn "unused?" comment #433

Merged
merged 3 commits into from
Nov 19, 2023

Conversation

Alchav
Copy link
Contributor

@Alchav Alchav commented Oct 22, 2023

Without this line, you are told you can't surf here when trying to surf in caves from stairs, unless you have bumped into the water first.

TilePairCollisionsWater contains the entry db CAVERN, $14, $05 which prevents surfing from raised cave ground tiles. If wTilePlayerStandingOn is not updated when the start menu is opened, it will be left at the previous tile, which will be the raised ground tile if you have just walked onto the stairs from one.

@Alchav Alchav changed the title Remove incorrect wTilePlayerStandingOn "unused" comment Remove incorrect wTilePlayerStandingOn "unused?" comment Oct 22, 2023
@Rangi42
Copy link
Member

Rangi42 commented Oct 22, 2023

Since someone thought it was unused at first, this explanation of why+how it's used would make a good comment on top of those lines.

home/overworld.asm Outdated Show resolved Hide resolved
@Rangi42 Rangi42 merged commit dc705d2 into pret:master Nov 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants