Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#221] 패키지 구조 및 명칭 변경 #240

Merged
merged 4 commits into from
Aug 10, 2023

Conversation

JoosungKwon
Copy link
Member

@JoosungKwon JoosungKwon commented Aug 6, 2023

🌱 작업 사항

  • 패키지 구조를 더욱 명확하게 표현하고자 유사한 폴더로 묶고 이름을 바꿔봤습니다.

스크린샷 2023-08-07 오전 1 41 30

  • security -> auth
  • report -> alarm
  • common -> base
  • exception -> base/exception
  • alarm, log, data는 infra로 두었습니다.
  • config도 기존에 전체 폴더 구조에서 유사한 폴더로 묶었습니다.
  • scheduler는 각 도메인에 포함 시켰습니다!

❓ 리뷰 포인트

  • 어떻게 생각하시나요? 확인해보시고 알려주세요. 목요일 회의 때 얘기하고 머지하겠습니다.
  • 혹시 추천이나 제안할 것이 있다면 알려주세요!

🦄 관련 이슈

@JoosungKwon JoosungKwon changed the title [#221]패키지 구조 및 명칭 변경 [#221] 패키지 구조 및 명칭 변경 Aug 6, 2023
@JoosungKwon JoosungKwon self-assigned this Aug 6, 2023
@JoosungKwon JoosungKwon force-pushed the develop branch 2 times, most recently from dbc3c05 to 3b3080a Compare August 8, 2023 07:04
- 더욱 명확하게 표현하고 복잡한 패키지를 유사한 폴더로 묶어서 관리할 수 있도록
@JoosungKwon JoosungKwon force-pushed the refactor/221-package-name branch from d3b8c7a to 92060aa Compare August 10, 2023 16:16
@github-actions
Copy link

📝 테스트 커버리지 리포트

File Coverage [76.41%] 🍏
ErrorResponse.java 100% 🍏
IdResponse.java 100% 🍏
ApiResponse.java 100% 🍏
P6spyConfig.java 100% 🍏
P6spyMessageFormatter.java 100% 🍏
RefreshTokenNotFoundException.java 100% 🍏
TokenException.java 100% 🍏
InvalidTokenException.java 100% 🍏
ExpiredTokenException.java 100% 🍏
NotFoundCookieException.java 100% 🍏
TokenController.java 100% 🍏
TokenService.java 100% 🍏
JwtTokenProvider.java 100% 🍏
OAuthAuthenticationFailureHandler.java 100% 🍏
ExistCrewMemberRoleException.java 100% 🍏
DuplicateProposalException.java 100% 🍏
InvalidProposalStatusException.java 100% 🍏
CrewMemberOverCapacity.java 100% 🍏
WebSocketConfig.java 100% 🍏
ReviewController.java 100% 🍏
CrewStatusException.java 100% 🍏
TokenResponse.java 100% 🍏
UserController.java 100% 🍏
BaseEntity.java 100% 🍏
ErrorCode.java 100% 🍏
JwtAuthenticationFilter.java 100% 🍏
JwtAuthenticationEntryPoint.java 100% 🍏
RedisConfig.java 100% 🍏
AwsS3Controller.java 100% 🍏
SchedulerConfig.java 100% 🍏
SecurityConfig.java 100% 🍏
CrewController.java 100% 🍏
CrewMemberController.java 100% 🍏
NotMemberException.java 100% 🍏
NotLeaderException.java 100% 🍏
ReviewResponse.java 100% 🍏
NotificationController.java 100% 🍏
InvalidNotificationContentException.java 100% 🍏
NotificationNotFoundException.java 100% 🍏
CustomOAuth2UserService.java 100% 🍏
OAuthProvider.java 100% 🍏
Tokens.java 100% 🍏
JpaConfig.java 100% 🍏
UserNotFoundException.java 100% 🍏
ProposalController.java 100% 🍏
StoreController.java 100% 🍏
AwsConfig.java 100% 🍏
LoggingAspect.java 97.96% 🍏
User.java 96.79% 🍏
OAuthAuthenticationSuccessHandler.java 96.43% 🍏
JwtAuthentication.java 94.12% 🍏
Store.java 93.79% 🍏
RefreshToken.java 92.81% 🍏
Proposal.java 91.87% 🍏
Crew.java 91.75% 🍏
Notification.java 90.99% 🍏
Chat.java 90.29% 🍏
Review.java 90.24% 🍏
AwsS3Service.java 89.63% 🍏
AwsS3.java 89.47% 🍏
CrewMemberService.java 87.8% 🍏
OAuthUserInfo.java 86.84% 🍏
CrewMember.java 85.85% 🍏
ServiceException.java 85.71% 🍏
AuthUserInfo.java 85.71% 🍏
ChatController.java 84.44% 🍏
ProposalServiceImpl.java 83.76% 🍏
StompHandler.java 83.69% 🍏
ReviewServiceImpl.java 83.57% 🍏
CrewService.java 82.35% 🍏
DefaultUserService.java 73.28% 🍏
CustomOAuth2User.java 72.97% 🍏
RequestInfo.java 70.97% 🍏
HttpCookieOAuthAuthorizationRequestRepository.java 70% 🍏
AsyncConfig.java 66.67% 🍏
InvalidNotificationAccessException.java 64.52% 🍏
GlobalExceptionHandler.java 55.41% 🍏
CrewScheduler.java 50% 🍏
ProposalScheduler.java 50% 🍏
ExceptionHandlerFilter.java 33.33%
JwtAuthenticationToken.java 26.23%
SlackNotificationAspect.java 22.3%
DataLoader.java 4.29%
CustomRequestLoggingFilter.java 2.19%
ReviewNotAccessException.java 0%
ReviewNotFoundException.java 0%
InsertQuery.java 0%
ApproveException.java 0%
ProposalNotFoundException.java 0%
CrewNotFoundException.java 0%
StoreNotFoundException.java 0%
LeaderNotFoundException.java 0%
MemberNotFoundException.java 0%
CrewMemberNotFoundException.java 0%
InvalidUserException.java 0%
WebSocketException.java 0%
Total Project Coverage 81.22% 🍏

@prgrms-web-devcourse prgrms-web-devcourse deleted a comment from github-actions bot Aug 10, 2023
@JoosungKwon JoosungKwon merged commit 3ba5d30 into develop Aug 10, 2023
@JoosungKwon JoosungKwon deleted the refactor/221-package-name branch August 10, 2023 16:24
JoosungKwon added a commit that referenced this pull request Aug 10, 2023
* fix: Redis ReadOnly 속성 문제 해결

* feat: global 패키지 명칭 변경

- 더욱 명확하게 표현하고 복잡한 패키지를 유사한 폴더로 묶어서 관리할 수 있도록

* feat: infra 패키지 jacoco추가

* chore: 변경 사항 반영
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant