이미지에 에러나거나 로드 안될 시 기본 이미지 렌더링 #210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
live-small
reviewed
May 3, 2023
Comment on lines
+98
to
+99
| fallbackStrategy={'onError' || 'beforeLoadOrError'} | ||
| fallbackSrc={DEFAULT_IMAGE} |
There was a problem hiding this comment.
오호 chakra image props에 이런 게 있었구나 👍
live-small
reviewed
May 3, 2023
Comment on lines
+1
to
+2
| export const DEFAULT_IMAGE = '/images/default-restaurant.svg'; | ||
|
|
There was a problem hiding this comment.
p3;
foodParty.ts에 DEFAULT_IMAGE라고 하면, 밥모임에 대한 기본이미지라고 오해할 수도 있을 거 같아요!
가게에 대한 이미지가 없을 때 보여주는 이미지 맞죠? 조금 더 구체적인 변수명으로 설정하는 건 어떨까요?
ex) DEFAULT_RESTAURANT_IMAGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 구현 내용
🖼 구현 이미지
✅ PR 포인트 & 궁금한 점