Add new landmarks renderers #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mi-sts
force-pushed
the
new-landmarks-renderers
branch
from
0326f48 to
b3cac8b
Compare
DmiitriyJarosh
approved these changes
May 1, 2024
src/main/kotlin/solve/rendering/engine/core/batch/RenderBatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/solve/rendering/engine/core/input/PointLayerClickHandler.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| fun initializeFramesRenderer() { | ||
| CoroutineScope(Dispatchers.Default).launch { |
There was a problem hiding this comment.
There is a problem with rendering process. The FramesRenderer needs to initialize a textures array on a GPU side before it can render frames, and it requires some time. The problem is that if we try to execute PlanesLayerRenderer (which also works with textures) at that time, the textures array of FramesRenderer doesn't initialize correctly, and we get "black" frames. I spent a lot of time on this bug, but still haven't figured it out.
| fun initializeFramesRenderer() { | ||
| CoroutineScope(Dispatchers.Default).launch { | ||
| isFramesRendererInitializing = true | ||
| delay(FrameRendererInitializationDelayMillis) |
There was a problem hiding this comment.
where is the real init process?
mi-sts
force-pushed
the
new-landmarks-renderers
branch
from
59ad3c2 to
d997fe9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2024-04-10.00-17-56.mp4