Reduced spacing between buttons in a button group to 0.25 rem

[MadMango]

Summary

Potentially fixes #504

Not sure if it should remain 0.5 rem for large buttons, happy to update this PR if so.

Also, I noticed that the buttonSize and buttonAs controls don't work in the storybook so I've created another pr for this here.

I couldn't get playwright to work reliably so I've not updated snapshots, but I think there's a pipeline workflow for this.

Not sure what I'm doing with changeset either so if it needs to look any different, please let me know 😄

List of notable changes:

Reduced spacing between buttons in a button group to 0.25 rem to match the designs

What should reviewers focus on?

Spacing between the buttons in a Button Group

Steps to test:

1. Open storybook and go to story/components-buttongroup--playground
2. Inspect the spacing between buttons

Contributor checklist:

• All new and existing CI checks pass
• Tests prove that the feature works and covers both happy and unhappy paths
• Any drop in coverage, breaking changes or regressions have been documented above
• New visual snapshots have been generated / updated for any UI changes
• All developer debugging and non-functional logging has been removed
• Related issues have been referenced in the PR description

Reviewer checklist:

• Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
• Check that tests prove the feature works and covers both happy and unhappy paths
• Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before	After

[changeset-bot]

🦋 Changeset detected

Latest commit: 8098900

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@primer/react-brand	Patch
@primer/brand-primitives	Patch
@primer/brand-e2e	Patch
@primer/brand-fonts	Patch
@primer/brand-config	Patch
@primer/brand-storybook	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[rezrah]

@MadMango thanks for opening this PR, and sorry for the delay in getting back to you. The Primer team have done some further investigation into the original request, and determined that this won't be something that we fix in the library

The original issue relates to the gap between the button label and adjacent arrow, not the gap between grouped buttons. This PR addresses the latter. We've also discovered that a 4px gap is already present, but optical alignment is leading to some indirection. You can find these details captured in the original issue.

Closing this for now, but thanks again for choosing to contribute to Primer Brand ✨