fix: Don’t use deprecated CSS properties in .sr-only
#2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
smockle
temporarily deployed
to
github-pages
GitHub Actions
Inactive
smockle
changed the title
.sr-only
jonrohan
approved these changes
Sep 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR replaces
clipandword-wrapin the.sr-onlyclass:clipis deprecated. MDN recommendsclip-pathinstead.word-wrapwas never a standard CSS property. MDN explains it is aliased tooverflow-wrap, which is standardized.What approach did you choose and why?
This PR replaces deprecated and non-standard CSS properties with supported and standardized ones, in order to ensure the
.sr-onlyclass works as expected.What should reviewers focus on?
Browser support for this PR’s replacement properties is good—all our supported browsers include them.
Do we have any tests that could ensure this change doesn’t visually regress?
Can these changes ship as is?