Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI issues #725

Merged
merged 7 commits into from
Apr 19, 2024
Merged

Fix CI issues #725

merged 7 commits into from
Apr 19, 2024

Conversation

owenniblock
Copy link
Contributor

@owenniblock owenniblock commented Apr 17, 2024

Motivation

Trying to fix the CI issues we're seeing.

  • I fixed the Primer React upgrade issue (<UnderlineNav.Link> becomes <UnderlineNav.Item>).
  • I fixed the styled-components upgrade issues

However, this revealed an issue with themes. I suspect this is because the ThemeProvider is coming from @primer/react and build against styled-components@5 so it's not playing nicely with styled-components@6

For now, I've rolled back the styled-components version upgrade. We can try this again when it's updated in the dependencies.

Copy link

changeset-bot bot commented Apr 17, 2024

⚠️ No Changeset found

Latest commit: fb352a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@owenniblock owenniblock marked this pull request as ready for review April 18, 2024 11:34
@owenniblock owenniblock requested a review from a team as a code owner April 18, 2024 11:34
@owenniblock owenniblock requested a review from TylerJDev April 18, 2024 11:34
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 👍

Copy link

@joshfarrant joshfarrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this @owenniblock 🙌

I've tested removing the optional chaining from live-code.js locally and it appears to work, but if you get chance it would be great to see if the CI is happy with that too

theme/src/components/live-code.js Outdated Show resolved Hide resolved
@owenniblock owenniblock enabled auto-merge (squash) April 19, 2024 08:36
@owenniblock owenniblock merged commit bce195c into main Apr 19, 2024
3 checks passed
@owenniblock owenniblock deleted the fix-ci-issues branch April 19, 2024 08:37
@dipree dipree mentioned this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants