-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI issues #725
Fix CI issues #725
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking at this @owenniblock 🙌
I've tested removing the optional chaining from live-code.js
locally and it appears to work, but if you get chance it would be great to see if the CI is happy with that too
Motivation
Trying to fix the CI issues we're seeing.
<UnderlineNav.Link>
becomes<UnderlineNav.Item>
).styled-components
upgrade issuesHowever, this revealed an issue with themes. I suspect this is because the
ThemeProvider
is coming from@primer/react
and build againststyled-components@5
so it's not playing nicely withstyled-components@6
For now, I've rolled back the
styled-components
version upgrade. We can try this again when it's updated in the dependencies.