Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: ensure announcement is made on dynamic content #5565

Closed
wants to merge 2 commits into from
Closed

docs: ensure announcement is made on dynamic content #5565

wants to merge 2 commits into from

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented Jan 17, 2025 •
edited
Loading

Fixes: https://github.com/github/accessibility-audits/issues/10031

Changed

Adds the announceOnShow attribute to the AlertStatus to ensure that polite announcements happen when the component is shown

Side note: I noticed these announcement components don't have a corresponding Primer docs page or guidance on how to use. Is that intentional? happy to follow up here separately.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Merge checklist

  • Added/updated previews (Storybook)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1359cd7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@khiga8 khiga8 marked this pull request as ready for review January 17, 2025 16:54
@khiga8 khiga8 requested a review from a team as a code owner January 17, 2025 16:54
@khiga8 khiga8 requested a review from francinelucca January 17, 2025 16:54
@khiga8 khiga8 added the skip changeset This change does not need a changelog label Jan 17, 2025
@khiga8 khiga8 changed the title Ensure announcement is made for dynamic content docs: ensure announcement is made on dynamic content Jan 17, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5565 January 17, 2025 16:57 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.22 KB (0%)
packages/react/dist/browser.umd.js 104.58 KB (0%)

@khiga8 khiga8 marked this pull request as draft January 17, 2025 17:00
@khiga8
Copy link
Contributor Author

khiga8 commented Jan 17, 2025

superceded by #5568

@khiga8 khiga8 closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francinelucca francinelucca Awaiting requested review from francinelucca francinelucca was automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@khiga8