Fix dialogs rendered inside menu items

[camertron]

What are you trying to accomplish?

A recent PR refactored the Dialog component to use the <dialog> element. This caused a flake to appear in our test suite, which uncovered an issue displaying dialogs that are rendered inside ActionMenu items, a use-case we support for when ActionMenu items are fetched async via <include-fragment>s. This PR addresses the flake and ensures dialogs inside menu items can be dismissed via the escape key.

Screenshots

Integration

No changes necessary in production.

Risk Assessment

• Low risk the change is small, highly observable, and easily rolled back.
• Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
• High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

See the comments in the code.

Accessibility

• No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Lookbook)
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

🦋 Changeset detected

Latest commit: d40b812

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/view-components	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[keithamus]

LGTM 😉