Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce ActionMenu test flakes #3143

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Reduce ActionMenu test flakes #3143

merged 2 commits into from
Oct 14, 2024

Conversation

camertron
Copy link
Contributor

Some of our ActionMenu tests are flaky and it's been irritating me for months now, so I finally decided to fix it.

Integration

No changes necessary in production - this is a test-only change.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

@camertron camertron added the skip changeset Pull requests that don't change the library output label Oct 8, 2024
Copy link

changeset-bot bot commented Oct 8, 2024

⚠️ No Changeset found

Latest commit: e694688

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@camertron camertron marked this pull request as ready for review October 9, 2024 17:09
@camertron camertron requested a review from a team as a code owner October 9, 2024 17:09
@camertron camertron requested review from broccolinisoup and jonrohan and removed request for broccolinisoup October 9, 2024 17:09
@camertron camertron merged commit c8b9b4b into main Oct 14, 2024
34 checks passed
@camertron camertron deleted the reduce_action_menu_flakes branch October 14, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants