Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gitignore for Primer forms move #3147

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Fix gitignore for Primer forms move #3147

merged 2 commits into from
Oct 14, 2024

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Oct 11, 2024

What are you trying to accomplish?

We're running into a weird test failure in dotcom where it appears none of the .d.ts files are available in the primer/view-components package. I believe the problem is due to a recent PR that moved the Primer forms code, but left a few old references inside the gitignore file. The .d.ts files are effectively being git ignored, which appears to prevent them from being packaged up and submitted to NPM.

This PR fixes the ignore paths. I have confirmed the .d.ts files are now available in the published packages on NPM.

Integration

No changes necessary in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: 5baf4a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@camertron camertron added the skip changeset Pull requests that don't change the library output label Oct 11, 2024
@camertron camertron merged commit 8587fc0 into main Oct 14, 2024
34 checks passed
@camertron camertron deleted the fix_forms_move branch October 14, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants