Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tsconfig output dir #3157

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fix tsconfig output dir #3157

merged 1 commit into from
Oct 17, 2024

Conversation

camertron
Copy link
Contributor

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

The types output dir in tsconfig.json is wrong and results in types not being available in dotcom, and I assume other apps.

Integration

No changes necessary in production - I'm submitting this PR to fix the current release.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

@camertron camertron added the skip changeset Pull requests that don't change the library output label Oct 17, 2024
@camertron camertron marked this pull request as ready for review October 17, 2024 16:59
Copy link

changeset-bot bot commented Oct 17, 2024

⚠️ No Changeset found

Latest commit: 0b66c17

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@camertron camertron requested a review from a team as a code owner October 17, 2024 16:59
@camertron camertron merged commit f910e67 into main Oct 17, 2024
19 of 20 checks passed
@camertron camertron deleted the fix_tsconfig_output_dir branch October 17, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant