Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(views): ORM-454 fix panic when specifying view as either end of a m2m relation #5137

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

FGoessler
Copy link
Contributor

Prisma does not currently support creating views. So it also cannot create relationships to them. But it should not blow up with an engine panic in this case.

Fixes prisma/prisma#19249.

@FGoessler FGoessler requested a review from a team as a code owner January 24, 2025 15:41
@FGoessler FGoessler requested review from wmadden and removed request for a team January 24, 2025 15:41
@FGoessler FGoessler added this to the 6.3.0 milestone Jan 24, 2025
Copy link
Contributor

github-actions bot commented Jan 24, 2025

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.120MiB 2.120MiB 0.000B
Postgres (gzip) 848.486KiB 848.485KiB 1.000B
Mysql 2.082MiB 2.082MiB 0.000B
Mysql (gzip) 834.397KiB 834.396KiB 1.000B
Sqlite 1.990MiB 1.990MiB 0.000B
Sqlite (gzip) 797.975KiB 797.975KiB 0.000B

Copy link

codspeed-hq bot commented Jan 24, 2025

CodSpeed Performance Report

Merging #5137 will not alter performance

Comparing fix/ORM-454-fix-views-realtion-crash (feb69a3) with main (2ad07dd)

Summary

✅ 11 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no entry found for key error on views<->model relations
1 participant