Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support basic deletes #5147

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: support basic deletes #5147

wants to merge 4 commits into from
+192 −52

Conversation

jacek-prisma
Copy link
Contributor

@jacek-prisma jacek-prisma commented Feb 3, 2025 •
edited
Loading

Closes ORM-560.

@jacek-prisma jacek-prisma requested a review from a team as a code owner February 3, 2025 15:41
@jacek-prisma jacek-prisma requested review from wmadden and removed request for a team February 3, 2025 15:41
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 3, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #5147 will not alter performance

Comparing feat/deletes-compiler (8a0ca6a) with main (705d9f6)

Summary

✅ 11 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited
Loading

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.120MiB 2.121MiB -784.000B
Postgres (gzip) 848.758KiB 848.673KiB 87.000B
Mysql 2.083MiB 2.083MiB -803.000B
Mysql (gzip) 834.330KiB 834.338KiB -9.000B
Sqlite 1.992MiB 1.991MiB 487.000B
Sqlite (gzip) 798.202KiB 797.948KiB 260.000B

@jacek-prisma jacek-prisma added this to the 6.4.0 milestone Feb 4, 2025
aqrln
aqrln approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@aqrln aqrln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aqrln aqrln aqrln approved these changes

@wmadden wmadden Awaiting requested review from wmadden wmadden is a code owner automatically assigned from prisma/orm-rust

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jacek-prisma @aqrln