Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade nightly toolchain for query-engine-wasm #5174

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Feb 21, 2025

It's pretty old at this point and we need a newer one to migrate to Rust 2024 after the stable toolchain is updated to 1.85.0.

An alternative is to use the stable toolchain for the wasm build (#5167) but it's currently blocked on the last comment in that PR.

It's pretty old at this point and we need a newer one to migrate to Rust
2024 after the stable toolchain is updated to 1.85.0.

An alternative is to use the stable toolchain for the wasm build
(#5167).
@aqrln aqrln added this to the 6.5.0 milestone Feb 21, 2025
Copy link

codspeed-hq bot commented Feb 21, 2025

CodSpeed Performance Report

Merging #5174 will not alter performance

Comparing push-wzoxnxvtmowl (eb7ed7b) with main (9e2c44c)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.113MiB 2.113MiB 181.000B
Postgres (gzip) 846.921KiB 846.876KiB 46.000B
Mysql 2.076MiB 2.075MiB 610.000B
Mysql (gzip) 832.834KiB 832.363KiB 483.000B
Sqlite 1.986MiB 1.984MiB 1.208KiB
Sqlite (gzip) 795.947KiB 795.543KiB 413.000B

@aqrln aqrln marked this pull request as ready for review February 21, 2025 13:44
@aqrln aqrln requested a review from a team as a code owner February 21, 2025 13:44
@aqrln aqrln requested review from jacek-prisma and removed request for a team February 21, 2025 13:44
@aqrln aqrln merged commit 45cea5e into main Feb 21, 2025
345 checks passed
@aqrln aqrln deleted the push-wzoxnxvtmowl branch February 21, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants