feat: support table field #375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dani-mp
reviewed
Jan 24, 2025
test/helpers-isFilled.test.ts
Outdated
| it("table", (/*ctx*/) => { | ||
| expect(isFilled.table(null)).toBe(false) | ||
| expect(isFilled.table(undefined)).toBe(false) | ||
| // expect(isFilled.table(ctx.mock.value.table())).toBe(true) |
There was a problem hiding this comment.
todo: uncomment this one when the mock is ready
dani-mp
reviewed
Jan 24, 2025
| * | ||
| * @returns `true` if `field` is filled, `false` otherwise. | ||
| */ | ||
| export const table = isNonNullish as ( |
There was a problem hiding this comment.
we might want to do something more sophisticated here, i.e. a table with no head and an empty body is probably "not filled", but it feels more like a product question
levimykel
commented
Jan 29, 2025
Comment on lines
229
to
231
| export type { GeoPointField } from "./types/value/geoPoint" | ||
| export type { TableField } from "./types/value/table" | ||
|
|
There was a problem hiding this comment.
I would alphabetize TableField and GeoPointField here, but it's not a big deal.
Comment on lines
291
to
293
| export type { CustomTypeModelGeoPointField } from "./types/model/geoPoint" | ||
| export type { CustomTypeModelTableField } from "./types/model/table" | ||
|
|
There was a problem hiding this comment.
I would alphabetize CustomTypeModelTableField and CustomTypeModelGeoPointField here, but it's not a big deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
https://linear.app/prismic/issue/DT-2584/[m]-aadev-when-i-add-a-table-field-i-can-see-the-according-type
Description
Adds table field type and value.
Checklist
Preview
How to QA 1
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩