Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support repeatable links #27

Merged
merged 7 commits into from
Dec 5, 2024
Merged

feat: support repeatable links #27

merged 7 commits into from
Dec 5, 2024

Conversation

dani-mp
Copy link
Collaborator

@dani-mp dani-mp commented Nov 11, 2024

Resolves:
https://linear.app/prismic/issue/DT-2426/aauser-in-slice-machine-when-i-create-a-new-link-with-repeat-property

Description

Checklist

  • A comprehensive Linear ticket, providing sufficient context and details to facilitate the review of the PR, is linked to the PR.
  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment.

Copy link

github-actions bot commented Nov 11, 2024

size-limit report 📦

Path Size
dist/index.js 11.15 KB (+0.35% 🔺)
dist/index.cjs 14.41 KB (-0.03% 🔽)

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.56%. Comparing base (2a7f0cb) to head (b918770).
Report is 35 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   83.39%   83.56%   +0.17%     
==========================================
  Files          82       82              
  Lines        1060     1071      +11     
  Branches      234      243       +9     
==========================================
+ Hits          884      895      +11     
  Misses        120      120              
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dani-mp dani-mp merged commit 4889d79 into main Dec 5, 2024
2 checks passed
@dani-mp dani-mp deleted the dani/repeatable-links branch December 5, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants