Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In key generation, figure out if we need l_0(X) computed more efficiently #269

Open
ed255 opened this issue Feb 2, 2024 · 1 comment
Open
Assignees

Comments

@ed255
Copy link
Member

ed255 commented Feb 2, 2024

In the key generation we find the following TODO:

// Compute l_0(X)
// TODO: this can be done more efficiently
let mut l0 = vk.domain.empty_lagrange();
l0[0] = C::Scalar::ONE;
let l0 = vk.domain.lagrange_to_coeff(l0);
let l0 = vk.domain.coeff_to_extended(l0);

We need to figure out:

  1. Is it worth doing this part more efficiently? In my opinion, if this part represents a <1% of the key gen time, there's no need to improve it.
  2. If we want to do it more efficiently, figure out how, and do it.
@adria0
Copy link
Member

adria0 commented Oct 2, 2024

@davidnevadoc is #363 closing this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants