Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Faster computation of L0 #363

Merged
merged 2 commits into from
Sep 16, 2024
Merged

feat: Faster computation of L0 #363

merged 2 commits into from
Sep 16, 2024

Conversation

davidnevadoc
Copy link

@davidnevadoc davidnevadoc commented Aug 20, 2024

Solves #269

This optimizations yields some modest imrpovements in key geneartion. For K=20

Keygen L0 gen
Previous 32.38 s 1.82 s
This PR 30.81 s 774 ms

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.67%. Comparing base (bc857a7) to head (6df6663).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
halo2_backend/src/poly/domain.rs 97.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
+ Coverage   82.64%   82.67%   +0.02%     
==========================================
  Files          84       84              
  Lines       17750    17786      +36     
==========================================
+ Hits        14670    14705      +35     
- Misses       3080     3081       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

refactor: parallelize denominator computation
@davidnevadoc davidnevadoc marked this pull request as ready for review September 9, 2024 09:02
Copy link

@guorong009 guorong009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@davidnevadoc davidnevadoc merged commit ee611ee into main Sep 16, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants