Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host docs ghpages #204

Merged

Conversation

thogiti
Copy link

@thogiti thogiti commented Sep 10, 2023

Created a github action workflow to host the docs on to github pages. Added an index.html at the root of docs folder.

@thogiti
Copy link
Author

thogiti commented Sep 10, 2023

Hello @CPerezz. I am a ZK Fellow from PSE's summer ZK Fellow program.

#140

I completed this task and now we can see the PSE's docs on github pages host. You can test it here:

https://thogiti.github.io/halo2/halo2/

I added a workflow through Github action to automate building the docs from PSE's root repo, add necessary index.html file in the correct path and deploy to github pages.

https://github.com/thogiti/halo2/blob/main/.github/workflows/docs-ghpages.yml

I also opened a PR on PSE's halo2 repo. If it is approved then I can update the link to the documentation from the main repo as a separate contribution.

Copy link
Member

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Will activate gh pages now and set it to docs folder.
Thanks for the PR!

Copy link

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ChihChengLiang ChihChengLiang merged commit 102a66d into privacy-scaling-explorations:main Sep 18, 2023
12 checks passed
@CPerezz
Copy link
Member

CPerezz commented Sep 18, 2023

@ChihChengLiang let's make sure that in the next deployment everything works smoothly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants