Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase code coverage #333

Merged
merged 23 commits into from
May 21, 2024
Merged

Increase code coverage #333

merged 23 commits into from
May 21, 2024

Conversation

adria0
Copy link
Member

@adria0 adria0 commented May 21, 2024

These changes should bump up coverage to 80%

  • Use llvm-cov instead tarpaulin
  • Disable coverage on graph & cost tools
  • Move some examples to tests, those examples suits more into the test category than as examples
  • Add unit test for Value. Also adds some #[must_use] that will help to catch errors.

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.95%. Comparing base (e262eaf) to head (411064b).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #333       +/-   ##
===========================================
+ Coverage   55.25%   80.95%   +25.69%     
===========================================
  Files          92       80       -12     
  Lines        9635    16499     +6864     
===========================================
+ Hits         5324    13356     +8032     
+ Misses       4311     3143     -1168     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adria0 adria0 merged commit c57b007 into main May 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants