Skip to content

Remove binding from powerquery #351

Remove binding from powerquery

Remove binding from powerquery #351

GitHub Actions / Clippy (beta) succeeded Oct 18, 2024 in 0s

Clippy (beta)

14 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 14
Note 0
Help 0

Versions

  • rustc 1.78.0 (9b00956e5 2024-04-29)
  • cargo 1.78.0 (54d8815d0 2024-03-26)
  • clippy 0.1.78 (9b00956 2024-04-29)

Annotations

Check warning on line 6 in halo2_backend/src/plonk/verifier/batch.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

fields `instances` and `proof` are never read

warning: fields `instances` and `proof` are never read
 --> halo2_backend/src/plonk/verifier/batch.rs:6:5
  |
5 | struct BatchItem<C: CurveAffine> {
  |        --------- fields in this struct
6 |     instances: Vec<Vec<Vec<C::ScalarExt>>>,
  |     ^^^^^^^^^
7 |     proof: Vec<u8>,
  |     ^^^^^
  |
  = note: `BatchItem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

Check warning on line 35 in halo2_backend/src/plonk/vanishing/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

field `h_blind` is never read

warning: field `h_blind` is never read
  --> halo2_backend/src/plonk/vanishing/prover.rs:35:5
   |
33 | pub(in crate::plonk) struct Evaluated<C: CurveAffine> {
   |                             --------- field in this struct
34 |     h_poly: Polynomial<C::Scalar, Coeff>,
35 |     h_blind: Blind<C::Scalar>,
   |     ^^^^^^^

Check warning on line 24 in halo2_backend/src/plonk/vanishing/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

field `random_blind` is never read

warning: field `random_blind` is never read
  --> halo2_backend/src/plonk/vanishing/prover.rs:24:5
   |
22 | pub(in crate::plonk) struct Committed<C: CurveAffine> {
   |                             --------- field in this struct
23 |     random_poly: Polynomial<C::Scalar, Coeff>,
24 |     random_blind: Blind<C::Scalar>,
   |     ^^^^^^^^^^^^

Check warning on line 32 in halo2_backend/src/plonk/shuffle/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

field `product_blind` is never read

warning: field `product_blind` is never read
  --> halo2_backend/src/plonk/shuffle/prover.rs:32:5
   |
30 | pub(in crate::plonk) struct Committed<C: CurveAffine> {
   |                             --------- field in this struct
31 |     pub(in crate::plonk) product_poly: Polynomial<C::Scalar, Coeff>,
32 |     product_blind: Blind<C::Scalar>,
   |     ^^^^^^^^^^^^^
   |
   = note: `Committed` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

Check warning on line 32 in halo2_backend/src/plonk/permutation/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

field `permutation_product_blind` is never read

warning: field `permutation_product_blind` is never read
  --> halo2_backend/src/plonk/permutation/prover.rs:32:5
   |
30 | pub(crate) struct CommittedSet<C: CurveAffine> {
   |                   ------------ field in this struct
31 |     pub(crate) permutation_product_poly: Polynomial<C::Scalar, Coeff>,
32 |     permutation_product_blind: Blind<C::Scalar>,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 43 in halo2_backend/src/plonk/lookup/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

fields `permuted_input_blind`, `permuted_table_blind`, and `product_blind` are never read

warning: fields `permuted_input_blind`, `permuted_table_blind`, and `product_blind` are never read
  --> halo2_backend/src/plonk/lookup/prover.rs:43:5
   |
41 | pub(in crate::plonk) struct Committed<C: CurveAffine> {
   |                             --------- fields in this struct
42 |     pub(in crate::plonk) permuted_input_poly: Polynomial<C::Scalar, Coeff>,
43 |     permuted_input_blind: Blind<C::Scalar>,
   |     ^^^^^^^^^^^^^^^^^^^^
44 |     pub(in crate::plonk) permuted_table_poly: Polynomial<C::Scalar, Coeff>,
45 |     permuted_table_blind: Blind<C::Scalar>,
   |     ^^^^^^^^^^^^^^^^^^^^
46 |     pub(in crate::plonk) product_poly: Polynomial<C::Scalar, Coeff>,
47 |     product_blind: Blind<C::Scalar>,
   |     ^^^^^^^^^^^^^
   |
   = note: `Committed` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
   = note: `#[warn(dead_code)]` on by default

Check warning on line 313 in halo2_proofs/benches/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> halo2_proofs/benches/plonk.rs:313:17
    |
313 |                 &vk,
    |                 ^^^ help: change this to: `vk`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `-W clippy::needless-borrow` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

Check warning on line 340 in halo2_proofs/benches/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused variable: `k`

warning: unused variable: `k`
   --> halo2_proofs/benches/plonk.rs:340:19
    |
340 |             |b, &(k, params, pk)| {
    |                   ^ help: if this is intentional, prefix it with an underscore: `_k`
    |
    = note: `#[warn(unused_variables)]` on by default

Check warning on line 6 in halo2_backend/src/plonk/verifier/batch.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

fields `instances` and `proof` are never read

warning: fields `instances` and `proof` are never read
 --> halo2_backend/src/plonk/verifier/batch.rs:6:5
  |
5 | struct BatchItem<C: CurveAffine> {
  |        --------- fields in this struct
6 |     instances: Vec<Vec<Vec<C::ScalarExt>>>,
  |     ^^^^^^^^^
7 |     proof: Vec<u8>,
  |     ^^^^^
  |
  = note: `BatchItem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

Check warning on line 35 in halo2_backend/src/plonk/vanishing/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

field `h_blind` is never read

warning: field `h_blind` is never read
  --> halo2_backend/src/plonk/vanishing/prover.rs:35:5
   |
33 | pub(in crate::plonk) struct Evaluated<C: CurveAffine> {
   |                             --------- field in this struct
34 |     h_poly: Polynomial<C::Scalar, Coeff>,
35 |     h_blind: Blind<C::Scalar>,
   |     ^^^^^^^

Check warning on line 24 in halo2_backend/src/plonk/vanishing/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

field `random_blind` is never read

warning: field `random_blind` is never read
  --> halo2_backend/src/plonk/vanishing/prover.rs:24:5
   |
22 | pub(in crate::plonk) struct Committed<C: CurveAffine> {
   |                             --------- field in this struct
23 |     random_poly: Polynomial<C::Scalar, Coeff>,
24 |     random_blind: Blind<C::Scalar>,
   |     ^^^^^^^^^^^^

Check warning on line 32 in halo2_backend/src/plonk/shuffle/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

field `product_blind` is never read

warning: field `product_blind` is never read
  --> halo2_backend/src/plonk/shuffle/prover.rs:32:5
   |
30 | pub(in crate::plonk) struct Committed<C: CurveAffine> {
   |                             --------- field in this struct
31 |     pub(in crate::plonk) product_poly: Polynomial<C::Scalar, Coeff>,
32 |     product_blind: Blind<C::Scalar>,
   |     ^^^^^^^^^^^^^
   |
   = note: `Committed` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

Check warning on line 32 in halo2_backend/src/plonk/permutation/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

field `permutation_product_blind` is never read

warning: field `permutation_product_blind` is never read
  --> halo2_backend/src/plonk/permutation/prover.rs:32:5
   |
30 | pub(crate) struct CommittedSet<C: CurveAffine> {
   |                   ------------ field in this struct
31 |     pub(crate) permutation_product_poly: Polynomial<C::Scalar, Coeff>,
32 |     permutation_product_blind: Blind<C::Scalar>,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 43 in halo2_backend/src/plonk/lookup/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

fields `permuted_input_blind`, `permuted_table_blind`, and `product_blind` are never read

warning: fields `permuted_input_blind`, `permuted_table_blind`, and `product_blind` are never read
  --> halo2_backend/src/plonk/lookup/prover.rs:43:5
   |
41 | pub(in crate::plonk) struct Committed<C: CurveAffine> {
   |                             --------- fields in this struct
42 |     pub(in crate::plonk) permuted_input_poly: Polynomial<C::Scalar, Coeff>,
43 |     permuted_input_blind: Blind<C::Scalar>,
   |     ^^^^^^^^^^^^^^^^^^^^
44 |     pub(in crate::plonk) permuted_table_poly: Polynomial<C::Scalar, Coeff>,
45 |     permuted_table_blind: Blind<C::Scalar>,
   |     ^^^^^^^^^^^^^^^^^^^^
46 |     pub(in crate::plonk) product_poly: Polynomial<C::Scalar, Coeff>,
47 |     product_blind: Blind<C::Scalar>,
   |     ^^^^^^^^^^^^^
   |
   = note: `Committed` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
   = note: `#[warn(dead_code)]` on by default