Skip to content

test: e2e full spent voting mode #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2025
Merged

test: e2e full spent voting mode #2441

merged 1 commit into from
May 10, 2025

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented May 7, 2025

Description

  • Add e2e tests for full credits voting mode
  • Improve non-qv e2e tests with additional checks
  • Use default qv mode in contracts deployment
  • Add full mode to contracts

Additional Notes

This is a last part of full voting mode implementation.

Related issue(s)

Closes #2314

Confirmation

Important

We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.

@0xmad 0xmad self-assigned this May 7, 2025
@0xmad 0xmad added this to MACI May 7, 2025
@0xmad 0xmad added the testing Issue/PR related to tests label May 7, 2025
Copy link

vercel bot commented May 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview May 10, 2025 10:59am

@0xmad 0xmad force-pushed the tests/e2e-full-spent branch from b61794f to b83c3be Compare May 7, 2025 18:49
@0xmad 0xmad moved this to In Progress in MACI May 7, 2025
@0xmad 0xmad force-pushed the tests/e2e-full-spent branch from b83c3be to 2b77224 Compare May 8, 2025 16:57
@0xmad 0xmad marked this pull request as ready for review May 9, 2025 14:05
@0xmad 0xmad enabled auto-merge May 9, 2025 14:05
@0xmad 0xmad requested a review from ctrlc03 May 9, 2025 14:05
@0xmad 0xmad force-pushed the tests/e2e-full-spent branch from 2b77224 to d52ad62 Compare May 9, 2025 14:47
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

- [x] Add e2e tests for full credits voting mode
- [x] Improve non-qv e2e tests with additional checks
- [x] Use default qv mode in contracts deployment
- [x] Add full mode to contracts
@ctrlc03 ctrlc03 force-pushed the tests/e2e-full-spent branch from ad7a4ce to 2429ff4 Compare May 10, 2025 10:54
@0xmad 0xmad merged commit ec5a063 into dev May 10, 2025
24 checks passed
@0xmad 0xmad deleted the tests/e2e-full-spent branch May 10, 2025 11:28
@github-project-automation github-project-automation bot moved this from In Progress to Done in MACI May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issue/PR related to tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat: enforce that all credits are spent on one option
2 participants