chore: cargo clippy fixes for 1.83.0 #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
th4s
approved these changes
Dec 12, 2024
| @@ -64,7 +64,7 @@ impl<const D: usize> LpnEncoder<D> { | |||
|
|
|||
| #[inline] | |||
| fn compute_one_row(&self, y: &mut [Block], x: &[Block], pos: usize, prp: &Prp) { | |||
| let block_size = (D + 4 - 1) / 4; | |||
| let block_size = D.div_ceil(4); | |||
There was a problem hiding this comment.
I am not sure if it is helpful here to follow clippy's advice. I suspect that this can create confusion so I would tend to suppress clippy or add a comment.
There was a problem hiding this comment.
I assume the Clippy team made this rule with severity error for a reason.
The docs says: It's simpler, clearer and more readable.
https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
rust-lang/rust-clippy#12894
There was a problem hiding this comment.
I don't have a strong opinion here. My thoughts were that I would probably spend a few extra brain cycles what happened to the original formula.
| @@ -47,7 +47,7 @@ impl Receiver<state::PreExtension> { | |||
| } | |||
|
|
|||
| // The range of each interval. | |||
| let k = (n + t - 1) / t; | |||
| let k = n.div_ceil(t); | |||
| @@ -50,7 +50,7 @@ impl Sender<state::PreExtension> { | |||
| } | |||
|
|
|||
| // The range of each interval. | |||
| let k = (n + t - 1) / t; | |||
| let k = n.div_ceil(t); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.