feature: pre-garbling #79
Conversation
| @@ -60,6 +61,10 @@ struct State { | |||
| received_values: HashMap<ValueId, ValueType>, | |||
| /// Values which have been decoded | |||
| decoded_values: HashSet<ValueId>, | |||
| /// Pre-transferred garbled circuits | |||
| /// | |||
| /// (inputs, outputs) => garbled circuit | |||
There was a problem hiding this comment.
I do not understand this comment line.
There was a problem hiding this comment.
It is just indicating that the inputs + outputs are used to map to the garbled circuit if it exists
There was a problem hiding this comment.
Ok, then maybe
| /// (inputs, outputs) => garbled circuit | |
| /// inputs and outputs from `receive_garbled_circuit` are used for one of the circuits from `garbled_circuits` |
There was a problem hiding this comment.
this is pretty verbose 🙃
There was a problem hiding this comment.
That's true. Do you have a shorter but more understandable idea? I do not think that the current comment is easily understandable, because I looked for input and output in the state variables, could not find them and was confused.
There was a problem hiding this comment.
Maybe worth emphaizing that (inputs, outputs) is unique to each circuit by making the comment
// A map used to look up a garbled circuit by its unique (inputs, outputs) reference.
sinui0
force-pushed
the
feature/pre-garble-2
branch
2 times, most recently
from
7168ba5 to
7669232
Compare
| @@ -60,6 +61,10 @@ struct State { | |||
| received_values: HashMap<ValueId, ValueType>, | |||
| /// Values which have been decoded | |||
| decoded_values: HashSet<ValueId>, | |||
| /// Pre-transferred garbled circuits | |||
| /// | |||
| /// (inputs, outputs) => garbled circuit | |||
There was a problem hiding this comment.
Maybe worth emphaizing that (inputs, outputs) is unique to each circuit by making the comment
// A map used to look up a garbled circuit by its unique (inputs, outputs) reference.
| @@ -229,8 +242,29 @@ impl Generator { | |||
| sink: &mut S, | |||
| hash: bool, | |||
| ) -> Result<(Vec<EncodedValue<encoding_state::Full>>, Option<Hash>), GeneratorError> { | |||
| let refs = CircuitRefs { | |||
There was a problem hiding this comment.
Seems like for the same inputs/outputs we may be getting different 'CircuitRefs' if they are passed in a different order.
There was a problem hiding this comment.
Yes that is true, this order dependence exists elsewhere in the codebase as well. I'm going to punt that out of scope of this PR tho. This is not a security issue but could cause a "cache-miss" or a deadlock
sinui0
force-pushed
the
feature/pre-garble-2
branch
from
7669232 to
c1e39f9
Compare
This PR implements "pre-garbling", aka the offline-online paradigm, for garbled circuits.
Changes
Loadtrait, an abstraction of this featureGeneratorandEvaluatorto support transferring of the encrypted gates prior to executionLoadforDEAPVM