Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate 'WithIo' OT traits #93

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Deprecate 'WithIo' OT traits #93

merged 1 commit into from
Jan 17, 2024

Conversation

sinui0
Copy link
Collaborator

@sinui0 sinui0 commented Jan 16, 2024

This PR deprecates these 'WithIo' traits, we don't use them anywhere nor do I expect us to anymore.

@sinui0 sinui0 requested review from themighty1 and th4s January 16, 2024 00:55
Copy link
Member

@th4s th4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Contains the commit from refactor/rename-mock, but I assume this is on purpose and it will be rebased.

@sinui0 sinui0 force-pushed the refactor/deprecate-with-io branch from e04747c to e2fe234 Compare January 17, 2024 19:14
@sinui0 sinui0 merged commit a874783 into dev Jan 17, 2024
3 checks passed
@sinui0 sinui0 deleted the refactor/deprecate-with-io branch January 17, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants