-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: chunk KOS extend message #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be cleaner to handle this in a general way in our messaging layer? Then this change would apply to every sink and stream we are using, while at the same time not mixing the protocol code with IO stuff.
I am thinking of something like wrapper functions in our IoSink
and IoStream
traits, which break down the payload if needed.
That thought certainly crossed my mind, but it didn't seem to be quite as straight forward.
|
Makes sense 👍, I haven't put that much thought into it when I wrote that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: dan <themighty1@users.noreply.github.com>
0cddc17
to
efb5f30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gw
This PR refactors KOS impl to chunk the extension message sent from the Receiver to the Sender.
Closes #97 and tlsnotary/tlsn-utils#10