perf: optimize pedersen and ipa commit #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaucube
approved these changes
Feb 14, 2025
winderica
approved these changes
Feb 15, 2025
Merged
via the queue into
privacy-scaling-explorations:main
with commit Feb 15, 2025
e9bebdb
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes Pedersen and IPA commitments gadgets, through the use of joint_scalar_mul_be and scalar_mul_le implemented here arkworks-rs/r1cs-std#155.
solves #201 (comment).
Benchmark
The Pedersen check circuit goes from 3,575,519 r1cs to 2,455,364 r1cs.
The IPA verify circuit also goes from 77,175 r1cs to 73,367 r1cs.