Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Port integration tests from zkevm-chains #1552

Open
ChihChengLiang opened this issue Aug 3, 2023 · 3 comments · Fixed by #1550
Open

Port integration tests from zkevm-chains #1552

ChihChengLiang opened this issue Aug 3, 2023 · 3 comments · Fixed by #1550
Assignees
Labels
T-feature Type: new features

Comments

@ChihChengLiang
Copy link
Collaborator

ChihChengLiang commented Aug 3, 2023

Describe the feature you would like

We deprecated the zkevm-chain repo, but there are integration tests we would like to keep running them.

The tests include:

Related issues

@ChihChengLiang ChihChengLiang added the T-feature Type: new features label Aug 3, 2023
@ChihChengLiang ChihChengLiang linked a pull request Aug 3, 2023 that will close this issue
3 tasks
@ChihChengLiang
Copy link
Collaborator Author

#1550 only generates the contracts for the tests, but we haven't added the actual tests yet.

Some more PRs are required to complete this task.

@ChihChengLiang ChihChengLiang reopened this Aug 7, 2023
@AronisAt79
Copy link
Contributor

next step: create blocks for benchmarking : issue #1557

@ChihChengLiang
Copy link
Collaborator Author

ChihChengLiang commented Aug 15, 2023

Note: Reevaluate where to remove or keep this https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/9e974d94e8491b482fc6293d4ab16b979cf346a2/zkevm-circuits/tests/prover_error.rs after the tests are ported.
If it is not used in the test then we should remove it.

@ed255 ed255 linked a pull request Sep 21, 2023 that will close this issue
@ed255 ed255 removed a link to a pull request Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-feature Type: new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants