This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Worst case benches - deploy wc contracts #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d state circuits)
…be restricted to view
…son recursion limit check
…rrode solc error 5776
github-actions
bot
added
the
crate-integration-tests
There was a problem hiding this comment.
Hi @AronisAt79,
I ported some comments from your fork. I also added comments on the solidity wrapper.
Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
|
@AronisAt79 don't be so hard on yourself, I don't think this is the worse case PR I have ever seen. |
|
The main function is very long, I wonder if we could split it in several functions that represent different steps in the process. I would be much easier to read. |
Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
leolara
reviewed
Aug 4, 2023
AronisAt79
changed the title
ChihChengLiang
approved these changes
Aug 4, 2023
leolara
approved these changes
Aug 4, 2023
|
LGTM! |
This was referenced Aug 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the first of a PRs series aiming to implement worst case block proof bench-marking tests within zkevm-circuits/integration-tests.
The changes submitted here implement the blockchain data generation functionality* needed for the wc bencmarks.
Type of change
✅ New feature (non-breaking change which adds functionality)
Contents
1. wcerrors.rs : Recreate the solc::SolcError and solc::SolcIoError types with necessary methods and private functions2. worst_case.rs: Recreate ethers::solc::Solc with necessary methods
3. gen_blockchain_data.rs
Rationale
Smart contracts written for generation of blocks with increased proof computational intensity use nested opcode calls in the inline assembly block that violate serde recursion limits.
Modules in Contents section 1 and 2 are created to manipulate the compilation behavior and disable recursion depth limits during deserializationError handling has also been added in gen_blockchain_data.rs in order to catch solc compilation errors hidden in the CompilerOutput struct
How Has This Been Tested?
https://github.com/privacy-scaling-explorations/zkevm-circuits/actions/runs/5749057365/job/15583140857https://github.com/privacy-scaling-explorations/zkevm-circuits/actions/runs/5753344249/job/15596341036