-
Notifications
You must be signed in to change notification settings - Fork 854
Meta: Opcode spec + implementation status #477
Comments
In #83 we kept track of opcode implementations in the bus-mapping, but I often missed quickly knowing the status of the opcode specs and circuit implementation. I've extended the list from #83 into a table to include the spec and circuit status. With this issue, #83 becomes redundant. @CPerezz do you think we can close the old issue? Or alternative rename the old issue and update it with this table (I didn't do that because I didn't want to confuse anyone) |
Ye! Makes sense to me! |
|
We currently have |
I did an update on the status of completion on 2023-04-28. Great work for all the progress :) |
Updated |
Updated the status of completion on Aug 9, 2023. All the specs were done, except |
Updated on Sep. 19, 2023 |
oh btw i can upstream better bus-mapping handling of self-destruct. It helps build correct statedb. Soon. https://github.com/scroll-tech/zkevm-circuits/blob/2723b82fb5d538d6fcc7b2dd0d84d3df8818499f/bus-mapping/src/evm/opcodes.rs#L499. it is battle tested with mainnet. |
@lispc https://github.com/scroll-tech/zkevm-circuits/blob/2723b82fb5d538d6fcc7b2dd0d84d3df8818499f/bus-mapping/src/evm/opcodes.rs#L499 Looks fantastic! It would be great to upstream it. |
Updated on Dec. 18, 2023. |
Error states
There are constant gas cases and dynamic gas cases. See #1305
ErrorGasUintOverflow
ininvalid tx
case. See discussion in ImplementErrGasUintOverflow
error state #1526The text was updated successfully, but these errors were encountered: