Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

bus-mapping: Implement Opcode trait for all non-storage-related OpcodeIds #83

Closed
51 of 78 tasks
CPerezz opened this issue Sep 21, 2021 · 3 comments
Closed
51 of 78 tasks

bus-mapping: Implement Opcode trait for all non-storage-related OpcodeIds #83

CPerezz opened this issue Sep 21, 2021 · 3 comments
Assignees
@rahulbs98 @ed255 @CPerezz
Labels
crate-bus-mapping Issues related to the bus-mapping workspace member help wanted Extra attention is needed

Comments

@CPerezz
Copy link
Member

CPerezz commented Sep 21, 2021 •
edited
Loading

This will be needed in order to have the capability of testing most of the traces that we might consider.

This will probably exclude opcodes like CALL, CALLDATACOPY etc.. As they might require a bit extra config and design.
@CPerezz CPerezz added enhancement crate-bus-mapping Issues related to the bus-mapping workspace member labels Sep 21, 2021
@CPerezz CPerezz self-assigned this Sep 21, 2021
@CPerezz CPerezz mentioned this issue Sep 21, 2021
Merged
@CPerezz
Copy link
Member Author

CPerezz commented Sep 27, 2021

Even though this is assigned to me, any contribution to trait implementations is welcomed as long as is first spec'd out and approved and the impl guidelines follow the previous implemented opcodes. 😄

@CPerezz CPerezz added the help wanted Extra attention is needed label Sep 27, 2021
@rahulbs98 rahulbs98 self-assigned this Oct 13, 2021
@rahulbs98 rahulbs98 linked a pull request Oct 25, 2021 that will close this issue
Implementing POP and MSTORE traits for Bus Mapping #140
Closed
@0xmountaintop
Copy link
Collaborator

0xmountaintop commented Dec 7, 2021 •
edited
Loading

Note that all these are based on #196, so need to wait for #196 being merged first

@ed255 ed255 mentioned this issue Dec 10, 2021
Closed
29 tasks
@ed255 ed255 mentioned this issue Apr 27, 2022
Closed
@CPerezz
Copy link
Member Author

CPerezz commented Apr 27, 2022

Closing in deref to #477

@CPerezz CPerezz closed this as completed Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rahulbs98 rahulbs98

@ed255 ed255

@CPerezz CPerezz

Labels
crate-bus-mapping Issues related to the bus-mapping workspace member help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implementing POP and MSTORE traits for Bus Mapping privacy-scaling-explorations/zkevm-circuits
4 participants
@rahulbs98 @ed255 @0xmountaintop @CPerezz