This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Add test for the codehash of the coinbase account. #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate-bus-mapping
z2trillion
force-pushed
the
fix/empty_coinbase
branch
from
750747c
to
4698ee7
Compare
|
Hi @z2trillion, what's the status of this PR? Any help needed to unblock it? |
z2trillion
force-pushed
the
fix/empty_coinbase
branch
from
4698ee7
to
e01b6bc
Compare
github-actions
bot
removed
the
crate-bus-mapping
z2trillion
force-pushed
the
fix/empty_coinbase
branch
from
e01b6bc
to
f8c0ca9
Compare
z2trillion
changed the title
|
Sorry, I forgot about this. The originally failing test now doesn't fail because of 242d38b, so now this PR consists of the regression test only. Feel free to close if it that's no longer needed. |
ChihChengLiang
approved these changes
Sep 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we did not set the code hash for coinbase accounts in the EndTxGadget. This was fixed in 242d38b. This PR adds a regression test.
Type of change