Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Combine LookupU8 and LookupU16 under Lookup(Table) #1514

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Combine LookupU8 and LookupU16 under Lookup(Table) #1514

merged 5 commits into from
Jul 6, 2023

Conversation

zemse
Copy link
Member

@zemse zemse commented Jul 4, 2023

Description

Combines LookupU8 and LookupU16 under Lookup(Table).

Issue Link

#1510

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor

@github-actions github-actions bot added the crate-zkevm-circuits Issues related to the zkevm-circuits workspace member label Jul 4, 2023
@zemse zemse force-pushed the 1510-combine-lookup-u8-u16 branch from 4e3aa7a to 5c2b437 Compare July 4, 2023 08:58
@zemse zemse marked this pull request as ready for review July 4, 2023 10:50
@hero78119 hero78119 self-requested a review July 5, 2023 10:13
hero78119
hero78119 approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@hero78119 hero78119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the contribution 🥇

ChihChengLiang
ChihChengLiang approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Beautiful refactor. Thanks for the contribution.

@ChihChengLiang ChihChengLiang added this pull request to the merge queue Jul 6, 2023
Merged via the queue into privacy-scaling-explorations:main with commit a884ae0 Jul 6, 2023
18 checks passed
@zemse zemse deleted the 1510-combine-lookup-u8-u16 branch January 31, 2024 09:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChihChengLiang ChihChengLiang ChihChengLiang approved these changes

@hero78119 hero78119 hero78119 approved these changes

Assignees
No one assigned
Labels
crate-zkevm-circuits Issues related to the zkevm-circuits workspace member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zemse @ChihChengLiang @hero78119