-
Notifications
You must be signed in to change notification settings - Fork 854
Fix testool manifest and add test it in github actions #1535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @adria0 new added CI step is failed
---- compiler::test::test_docker_solidity stdout ----
Error: docker ["run", "-i", "--rm", "solc", "--standard-json", "-"] failed "Unable to find image 'solc:latest' locally\ndocker: Error response from daemon: pull access denied for solc, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.\nSee 'docker run --help'.\n" when compiling >>>"{\"language\":\"Solidity\",\"settings\":{\"optimizer\":{\"enabled\":false,\"details\":{\"jumpdestRemover\":false,\"peephole\":false,\"inliner\":false}},\"outputSelection\":{\"*\":{\"*\":[\"evm.bytecode\"]}}},\"sources\":{\"stdin\":{\"content\":\"contract A{}\"}}}"<<<
---- compiler::test::test_docker_yul stdout ----
Error: docker ["run", "-i", "--rm", "solc", "--standard-json", "-"] failed "Unable to find image 'solc:latest' locally\ndocker: Error response from daemon: pull access denied for solc, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.\nSee 'docker run --help'.\n" when compiling >>>"{\"language\":\"Yul\",\"settings\":{\"optimizer\":{\"enabled\":false,\"details\":{\"jumpdestRemover\":false,\"peephole\":false,\"inliner\":false}},\"outputSelection\":{\"*\":{\"*\":[\"evm.bytecode\"]}}},\"sources\":{\"stdin\":{\"content\":\"\\n{\\n function power(base, exponent) -> result\\n {\\n result := 1\\n for { let i := 0 } lt(i, exponent) { i := add(i, 1) }\\n {\\n result := mul(result, base)\\n }\\n }\\n}\\n \"}}}"<<<
---- compiler::test::test_docker_lll stdout ----
Error: docker ["run", "-i", "--rm", "lllc"] failed "Unable to find image 'lllc:latest' locally\ndocker: Error response from daemon: pull access denied for lllc, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.\nSee 'docker run --help'.\n" when compiling >>>"[[0]] (+ 0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff 4)"<<<
failures:
compiler::test::test_docker_lll
compiler::test::test_docker_solidity
compiler::test::test_docker_yul
Seems the reason is need to execute testtool/test-docker.sh
in advanced to build the docker image locally
ab1f790
to
ebbf695
Compare
Hey @hero78119 , thanks for checking this! |
ebbf695
to
68db8bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
hey @adria0, noticed test-docker.sh
also removed, which might lost the information for how to build the docker to run locally. If docker still need, should we docs the build step in README.md as pre-setup step ?
Yep, agree! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Testool failed to compile after #1524, this is due:
test-circuits
featureType of change
Bug fix (non-breaking change which fixes an issue)
Contents