Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

use StepRws to make rw index less error prone #1582

Merged
merged 1 commit into from
Sep 6, 2023
Merged

use StepRws to make rw index less error prone #1582

merged 1 commit into from
Sep 6, 2023

Conversation

ChihChengLiang
Copy link
Collaborator

Description

Manually counting read-write indices is error-prone. We use the StepRws struct to automatically track read-write indices.

This PR is motivated by trying to fix #1565. Unfortunately, this PR alone doesn't fix #1565.

Issue Link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@github-actions github-actions bot added the crate-zkevm-circuits Issues related to the zkevm-circuits workspace member label Sep 5, 2023
@ChihChengLiang ChihChengLiang marked this pull request as ready for review September 5, 2023 17:33
ed255
ed255 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hero78119 hero78119 self-requested a review September 6, 2023 08:38
hero78119
hero78119 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@hero78119 hero78119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChihChengLiang ChihChengLiang added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit cee187b Sep 6, 2023
18 checks passed
@ChihChengLiang ChihChengLiang deleted the rw_steps branch September 6, 2023 09:19
@ChihChengLiang ChihChengLiang mentioned this pull request Sep 6, 2023
Closed
16 tasks
@nullity00 nullity00 mentioned this pull request Sep 19, 2023
Closed
17 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hero78119 hero78119 hero78119 approved these changes

@ed255 ed255 ed255 approved these changes

Assignees
No one assigned
Labels
crate-zkevm-circuits Issues related to the zkevm-circuits workspace member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChihChengLiang @hero78119 @ed255