Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

[MPTWG] Update CI for MPTWG #1591

Merged
merged 3 commits into from
Sep 12, 2023
Merged

[MPTWG] Update CI for MPTWG #1591

merged 3 commits into from
Sep 12, 2023

Conversation

ChihChengLiang
Copy link
Collaborator

Description

Enable the MPT witness generator CI check

Issue Link

Type of change

Bug fix (non-breaking change which fixes an issue)

Contents

  • Run Go build and Go format on MPTWG
  • Ignore main tests CI run if no change on zkevm-circuits
  • Ignore MPTWG CI run if no change on MPTWG

Rationale

We want to enable automatic checks on MPTWG

@github-actions github-actions bot added the CI Issues related to the Continuous Integration mechanisms of the repository. label Sep 9, 2023
@ChihChengLiang ChihChengLiang changed the title update CI for MPTWG [MPTWG] Update CI for MPTWG Sep 9, 2023
@ChihChengLiang ChihChengLiang marked this pull request as ready for review September 9, 2023 04:41
@miha-stopar miha-stopar self-requested a review September 11, 2023 14:47
Copy link
Collaborator

@miha-stopar miha-stopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChihChengLiang ChihChengLiang added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit 7526cbd Sep 12, 2023
13 checks passed
@ChihChengLiang ChihChengLiang deleted the mptwg-ci branch September 12, 2023 16:13
github-merge-queue bot pushed a commit that referenced this pull request Sep 14, 2023
### Description

Remove dead code in MPTWG to improve readability.

### Issue Link


### Type of change

Bug fix (non-breaking change which fixes an issue)


(wait CI update in #1591)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI Issues related to the Continuous Integration mechanisms of the repository.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants