This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
fix unconstrained is_warm in sload/sstore #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate-bus-mapping
lightsing
changed the title
|
Hi @lightsing, I see failing tests |
The unit test assertion need to be updated due to rw changes, on it |
ChihChengLiang
approved these changes
Sep 12, 2023
lispc
approved these changes
Sep 12, 2023
Merged
via the queue into
privacy-scaling-explorations:main
with commit Sep 12, 2023
77c16e4
11 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the soundness problem in the implementation of SLOAD and SSTORE opcodes by adding constraints to the
is_warmcell. The problem is detailed in issue #1049.Issue Link
#1049
Type of change
Contents
bus-mapping/src/evm/opcodes/sload.rsbus-mapping/src/evm/opcodes/sstore.rszkevm-circuits/src/evm_circuit/execution/sload.rszkevm-circuits/src/evm_circuit/execution/sstore.rsRationale
The current implementation of SSTORE and SLOAD didn't constrain the
is_warmcell, which could result in any value and lead to soundness problems. This PR adds constraints to theis_warmcell in order to ensure correctness.How Has This Been Tested?