This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
[fix] end_tx circuit coinbase transfer #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate-zkevm-circuits
ed255
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
LGTM! Thanks for the fix!
This is related to #1600 (comment) and should finally fix #1581
ChihChengLiang
approved these changes
Sep 18, 2023
lispc
merged commit ba4cb0b
into
privacy-scaling-explorations:feat/testool_scroll
13 checks passed
ChihChengLiang
pushed a commit
that referenced
this pull request
Sep 20, 2023
### Description fix end_tx circuit coinbase transfer ### Issue Link https://github.com/privacy-scaling-explorations/zkevm-circuits/actions/runs/6180463331/job/16776966002?pr=1581 ### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Contents - add rw_delta to TransferTo ### Rationale N/A ### How Has This Been Tested? previous failed unit test passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix end_tx circuit coinbase transfer
Issue Link
https://github.com/privacy-scaling-explorations/zkevm-circuits/actions/runs/6180463331/job/16776966002?pr=1581
Type of change
Contents
Rationale
N/A
How Has This Been Tested?
previous failed unit test passed