Skip to content

Harden relay SSRF validation with post-resolution IP filtering #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwsantiago merged 16 commits into from
Feb 26, 2026
Merged

Harden relay SSRF validation with post-resolution IP filtering #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
cddb358
Harden SSRF validation with post-resolution IP filtering
wksantiago Feb 25, 2026
debafa2
Fix cargo fmt formatting
wksantiago Feb 25, 2026
b706b6a
Add allow-ws feature flag for test relay URLs
wksantiago Feb 25, 2026
5d48124
Block deprecated IPv6 site-local fec0::/10 in SSRF validation
wksantiago Feb 25, 2026
4aaacea
Fix SSRF checks bypassed by workspace feature unification
wksantiago Feb 25, 2026
c5e334b
Skip internal host check when allow-ws feature is enabled
wksantiago Feb 25, 2026
1814d31
Decouple SSRF guard from allow-ws and block NAT64 WKP embedded IPv4
wksantiago Feb 25, 2026
71b07c2
Fix fmt and enable allow-internal for frost-net tests
wksantiago Feb 25, 2026
04f38bb
Add URL-level tests for IPv4-compatible and NAT64 embedded address SS…
wksantiago Feb 25, 2026
f2da036
Fix SSRF guard bypassed by Cargo feature unification
wksantiago Feb 26, 2026
52fa2b4
Fix allow-internal feature not activating for frost-net tests
wksantiago Feb 26, 2026
934b379
Harden SSRF: 6to4, Teredo, doc-prefix, userinfo, .arpa/.onion
kwsantiago Feb 26, 2026
6a3607e
Simplify SSRF guard: use net type imports, consistent naming
kwsantiago Feb 26, 2026
d8bd779
Fix fmt
kwsantiago Feb 26, 2026
88bfd43
Add fec0::/10 test coverage and bunker relay empty-fallback
kwsantiago Feb 26, 2026
0ea879f
Run reproducible build only on push to main
kwsantiago Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:

reproducible:
runs-on: ubuntu-latest
if: github.event.pull_request.draft != true
if: github.event_name == 'push'
steps:
- uses: actions/checkout@v6
- name: Build twice and compare
Expand Down
3 changes: 3 additions & 0 deletions keep-core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ license = "AGPL-3.0-or-later"
[features]
default = []
testing = []
allow-ws = []
# WARNING: allow-internal disables SSRF internal-host checks. MUST NOT be enabled in production.
allow-internal = []

[dependencies]
argon2 = "0.5"
Expand Down
Loading